add tast solution #4042
add tast solution #4042
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the Sum component! The functionality is working correctly, and you've successfully handled all the prop requirements.
I'm requesting one change in src/components/Sum/Sum.jsx to meet a specific project guideline. The way the output string is constructed violates a checklist item [CHECKLIST ITEM #2]. Please update the content inside the <p> tag to use a single template literal for better readability and consistency.
Here's how it should look:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Once you make this small adjustment, your solution will be perfect. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'. The requirement is to use a single template literal for the entire string to improve readability, like {Sum of ${a} and ${b} is ${a + b}}.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent progress on this! You're very close to the correct solution. The main issue is in src/components/Sum/Sum.jsx, where the sum is being displayed as plain text instead of the calculated result.
To make JSX evaluate your template string as a JavaScript expression, you need to wrap the entire thing in curly braces {}. Without them, it's just treated as a regular string.
Required change:
// In src/components/Sum/Sum.jsx
// Change this:
<p>`Sum of ${a} and ${b} is ${a + b}`</p>
// To this:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>This small fix will get the component working as intended and satisfy the requirements. [CHECKLIST ITEM #2]
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of ${a} and ${b} is ${a + b} |
There was a problem hiding this comment.
This is very close to the correct solution! To make JSX evaluate this template string as JavaScript and insert the variable values, you need to wrap the entire expression in curly braces {}. Without the braces, it's just treated as plain text.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this revision! You've successfully implemented the Sum component, and it correctly calculates and displays the result as required. The code is clean, well-structured, and fully meets all the task requirements. It's great to see that you've also set up the App component perfectly with all the necessary instances. I am approving your solution, keep up the fantastic work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://dianakerekesha.github.io/react_sum/